feat(client): add ability to provide grpc dial options like client interceptors #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hifabienne
added
the
os-contribution
livio-a
changed the title
|
@sashayakovtseva Thank you for the PR! If you want a small gift for your contribution, please reach out to [email protected]. |
livio-a
approved these changes
Jul 25, 2024
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #349.
A new client option to add custom grpc dial options to Zitadel client is added.
I understand that #349 is in the product backlog, but since I already need metrics I took liberty and prepared this PR. Let me know if I need to alter my code somehow for this PR to be accepted. Thanks!
Definition of Ready